feat(protocol-designer): update heater shaker form fields #16580
+162
−88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR overhauls the new PD heater shaker form. I consolidate shake duration form field (minutes and seconds) into a single time field. I also fix the function of the HS form toggle input fields and update errors, maskers, and default values for the form. I also add form-level HS form errors to catch required fields when they are toggled but no input is given.
Closes AUTH-864, Closes AUTH-966
Test Plan and Hands on Testing
Changelog
heaterShakerTimer
form fieldgetTimeFromForm
utility to work with heater shaker form in addition to pause formReview requests
Risk assessment
medium. Modifies behavior of heater shaker form to args. I checked tests and exported protocols with the new consolidated
timer
field, and all looks correct.